Skip to content

PHP 7.4 support #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2020
Merged

PHP 7.4 support #221

merged 4 commits into from
May 8, 2020

Conversation

lenaorobei
Copy link
Contributor

@lenaorobei lenaorobei commented May 8, 2020 •
edited by sdzhepa
Loading

Description (*)

Fixed Issues (if relevant)

Fixes #206 : PHP 7.4 support

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lenaorobei
Copy link
Contributor Author

lenaorobei commented May 8, 2020 •
edited
Loading

PHP 7.4 with SD https://m2build-ur.devops.magento.com/view/all/job/All-User-Requested-Tests/32513/
PHP 7.3 with SD https://m2build-ur.devops.magento.com/view/all/job/All-User-Requested-Tests/32518/

@sdzhepa sdzhepa linked an issue May 8, 2020 that may be closed by this pull request
PHP 7.4 support #206
Closed
@lenaorobei
Copy link
Contributor Author

@magento run all tests

@lenaorobei lenaorobei merged commit a132844 into 1.0.0-develop May 8, 2020
@naydav naydav deleted the 1.0.0-develop-php74 branch May 12, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 7.4 support
1 participant
@lenaorobei