Skip to content

Update default OTP Window for Google TOTP to 1 per recommendation in RFC 6238 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Update default OTP Window for Google TOTP to 1 per recommendation in RFC 6238 #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
766064b
Update default OTP Window to 1 per recommendation in RFC 6238
davidalger Jun 9, 2020
efef37f
Merge branch '1.0-develop' into patch-1
davidalger Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TwoFactorAuth/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<field id="otp_window" translate="label comment" type="text" sortOrder="10" showInDefault="1"
showInWebsite="0" showInStore="0" canRestore="1">
<label>OTP Window</label>
<comment>This determines how long the one-time-passwords are valid for.</comment>
<comment>This determines how long the one-time-passwords are valid for. An OTP Window of 1 will result in the current OTP value plus 1 code in the past and 1 code in the future to be valid at any given point in time.</comment>
</field>
</group>
<group id="duo" translate="label" type="text" sortOrder="40" showInDefault="1" showInWebsite="0"
Expand Down
2 changes: 1 addition & 1 deletion TwoFactorAuth/etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<application_key backend_model="Magento\Config\Model\Config\Backend\Encrypted"/>
</duo>
<google>
<otp_window>30</otp_window>
<otp_window>1</otp_window>
</google>
</twofactorauth>
</default>
Expand Down