Skip to content

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jun 15, 2020

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@jilu1 jilu1 changed the title MQE-2194: fix mftf tests static check failures [MFTF] [1.0.0-develop] MQE-2194: fix mftf tests static check failures Jun 15, 2020
@jilu1 jilu1 requested a review from ishakhsuvarov June 16, 2020 16:25
@jilu1
Copy link
Contributor Author

jilu1 commented Jun 16, 2020

This PR is critical for MFTF team to enable static checks on builds. @ishakhsuvarov Can you please review and process it as a priority?

@nathanjosiah
Copy link
Contributor

@magento run all tests

@jilu1
Copy link
Contributor Author

jilu1 commented Jun 17, 2020

@magento run all tests

@jilu1
Copy link
Contributor Author

jilu1 commented Jun 17, 2020

@magento run ee tests

@jilu1
Copy link
Contributor Author

jilu1 commented Jun 17, 2020

@nathanjosiah Tests are green and pr ready to merge

@nathanjosiah nathanjosiah merged commit 0a32b7c into magento:1.0.0-develop Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants