Skip to content

magento/security-package#222: Add validation for error message. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 14, 2020
Merged

magento/security-package#222: Add validation for error message. #259

merged 10 commits into from
Aug 14, 2020

Conversation

engcom-Foxtrot
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Add validation for error message. #222: Add validation for error message.

Manual testing scenarios (*)

  1. See Add validation for error message. #222: Add validation for error message.

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Foxtrot engcom-Foxtrot requested a review from naydav July 24, 2020 15:32
@naydav naydav added the Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label label Jul 31, 2020
@irenelagno
Copy link

The team checked with Doc team and agreed to use:
The team added messages "reCAPTCHA verification failed."
"Something went wrong with reCAPTCHA. Please contact the store owner."
@smiverma, do you have any objections?

@smiverma
Copy link

smiverma commented Aug 6, 2020

No objections with the message

The team checked with Doc team and agreed to use:
The team added messages "reCAPTCHA verification failed."
"Something went wrong with reCAPTCHA. Please contact the store owner."
@smiverma, do you have any objections?

@naydav
Copy link
Contributor

naydav commented Aug 7, 2020

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests

@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests

@engcom-Foxtrot engcom-Foxtrot changed the title [WIP] magento/security-package#222: Add validation for error message. magento/security-package#222: Add validation for error message. Aug 7, 2020
@engcom-Delta engcom-Delta self-assigned this Aug 10, 2020
@engcom-Delta
Copy link

Recaptcha failure messages cannot be set for PayPal PayflowPro payment form from reCAPTCHA Failure Messages section
image

Scope for reCAPTCHA Failure Messages in Google reCAPTCHA Admin Panel section should be changed from store view to global
image

@engcom-Foxtrot
Copy link
Contributor Author

Recaptcha failure messages cannot be set for PayPal PayflowPro payment form from reCAPTCHA Failure Messages section
image

Scope for reCAPTCHA Failure Messages in Google reCAPTCHA Admin Panel section should be changed from store view to global
image
@engcom-Delta updated, please retest.

@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests

@engcom-Delta
Copy link

✔️ QA passed
Was checked cases with wrong Google API Secret Key, with Minimum Score Threshold=1, set different reCAPTCHA Validation Failure Message and reCAPTCHA Technical Failure Message by Website/Store View scopes
#259PRWrongSecret
#259PRMinScore1
Peek 2020-08-10 16-27

@engcom-Foxtrot
Copy link
Contributor Author

@magento run all tests

@naydav naydav merged commit 39f934e into 1.0-develop Aug 14, 2020
@naydav naydav mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naydav naydav Awaiting requested review from naydav

Assignees

@engcom-Delta engcom-Delta

Labels

Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label Progress: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@engcom-Foxtrot @irenelagno @smiverma @naydav @engcom-Delta