Skip to content

#212 - Implement ListView & ListViewItem on iOS. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
9 commits merged into from
Nov 12, 2019
Merged

#212 - Implement ListView & ListViewItem on iOS. #221

9 commits merged into from
Nov 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2019

ref: #212

SofomoMobile and others added 7 commits November 7, 2019 10:57
@SofomoMobile
Initial code structure.
001db08
@SofomoMobile
Next step.
51ce1f6
@pleszkiewicz
Debug scene for list view (WIP)
dbd88d2
@pleszkiewicz
Merge branch 'master' into feature/#212-listView_iOS
c16920b 
# Conflicts:
#	ios/RNMagicScriptHostApplication/sources/ViewController.swift
@pleszkiewicz
Set scene scale to 0.5.
8a59d63
@SofomoMobile
UnitTests updated.
b0d16c9
@SofomoMobile
Merge branch 'master' into feature/#212-listView_iOS
7e20ed8 
* master:
  Update ComponentImplementations.md
  UiColorPicker - orientation change fix.
@ghost ghost added the iOS Related to iOS platform. label Nov 12, 2019
@ghost ghost requested a review from pleszkiewicz November 12, 2019 09:32
@ghost ghost self-assigned this Nov 12, 2019
@kpiascik
Copy link
Contributor

kpiascik commented Nov 12, 2019 •
edited
Loading

Codecov Report

Merging #221 into master will decrease coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #221      +/-   ##
============================================
- Coverage     44.23%   44.22%   -0.02%     
  Complexity      421      421              
============================================
  Files           101      102       +1     
  Lines          3009     3012       +3     
  Branches        422      422              
============================================
+ Hits           1331     1332       +1     
- Misses         1499     1501       +2     
  Partials        179      179
Flag Coverage Δ Complexity Δ
#javascript 36.5% <40%> (-0.04%) 0 <0> (ø)
#kotlin 44.92% <ø> (ø) 421 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...platform/elements/builders/listviewitem-builder.js 0% <0%> (ø) 0 <0> (ø) ⬇️
...nts/platform/elements/builders/listview-builder.js 0% <0%> (ø) 0 <0> (?)
components/platform/component-mapping.js 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c08000...926034d. Read the comment docs.

pleszkiewicz
pleszkiewicz approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@pleszkiewicz pleszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code 👍

@ghost ghost merged commit 3352423 into master Nov 12, 2019
@ghost ghost deleted the feature/#212-listView_iOS branch November 12, 2019 11:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
iOS Related to iOS platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpiascik @pleszkiewicz @SofomoMobile