Improve/Nodes adjustments on Android #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
darek607
commented
Jan 29, 2020
darek607
commented
- adjustments to button, toggle and dropdown (after comparing with ML1),
- unit tests improvements
added 8 commits
January 27, 2020 15:22
…/magic-script/magic-script-components-react-native into improve/nodes_adjustmens_android
panwrona
approved these changes
Jan 30, 2020
| @@ -412,4 +412,11 @@ abstract class UiNode( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| class Test(private val uiNode: UiNode) { | |||
There was a problem hiding this comment.
With private uiNode you can only trigger performClick() method, you won't be able to test it like this:
val testNode = UiNode.Test(UiButtonNode(...))
testNode.uiNode.methodInvoke()| @@ -444,4 +433,18 @@ abstract class TransformNode( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| class Test(private val node: TransformNode) { | |||
There was a problem hiding this comment.
Same as below, with private you can't test the node wrapped in Test class
panwrona
pushed a commit
that referenced
this pull request
Feb 7, 2020
* nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * cr fixes
panwrona
pushed a commit
that referenced
this pull request
Feb 12, 2020
* nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * cr fixes
panwrona
pushed a commit
that referenced
this pull request
Feb 12, 2020
* nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * cr fixes
panwrona
added a commit
that referenced
this pull request
Feb 12, 2020
* Update toggles assets. * Adjust toggle layout. * fitXY scale mode for images * Update toggles asset. * drawing tab witout border * Make progressBar static variables public. * Fix unit tests. * scrolbar properties rename * Update. * Set padding alignment per item (#390) * Set padding/alignment per item ref: #388 * component size fixes * padding/alignment list refactor * cr fix * cr fix * cr fix * Improve/Dropdown adjustments (#392) * dropdown event adjustments * multi selection * dropdown fixes and tests * selected property support and refactor * dropdown fixes, bold typeface for selected items, tests * native list view for dropdown items * custom adapter * padding and fixes * text size, background, fixes * selecting item in native list view, fixes * rednering dropdown at top of otehr views, fixes * dropdown background * tests update for dropdown, refactor * cr fixes part1 * cr refactor part 2 * refactor * Bugfix/Layouts bounds calculation fix (#401) * layout bounds calculation fix * tests improvement * Fixed padding/alignment per item in PageView (#403) * Fixed padding/alignment per item in PageView also tests for LayoutUtils ref #402 * Fixed padding/alignment per item in PageView also tests for LayoutUtils ref #402 * Improve/New toggles graphics (#404) * replaced png to vector icons * colors adjsutments * alignment and spacing fix for toggles * GH Actions for feature branches on JSX & Android updated. (#405) * updated the tested properties and events (#406) * HotFIX: GHAction trigger. * Updated props for GridLayout padding and alignment (#407) * Updated props for GridLayout padding and alignment ref:#402 * containsAll refactor&tests * Improve/Nodes adjustments on Android (#408) * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * cr fixes * iOS RN Bridge performance improvement. (#412) * PlaneDetector common interface & iOS. (#410) * Initial implementation. * UTs updated. * Vertices transformed with anchor.transform. * SurfaceNode - initial implementation. * SurfaceNode tap - initial implementation. * UTs update & post review fixes. * Improve/Dropdown adjustments (#392) * dropdown event adjustments * multi selection * dropdown fixes and tests * selected property support and refactor * dropdown fixes, bold typeface for selected items, tests * native list view for dropdown items * custom adapter * padding and fixes * text size, background, fixes * selecting item in native list view, fixes * rednering dropdown at top of otehr views, fixes * dropdown background * tests update for dropdown, refactor * cr fixes part1 * cr refactor part 2 * refactor * Improve/Nodes adjustments on Android (#408) * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * nodes adjustments after comparision with ML1 * dropdown,button and toggle adjustments * unit tests and refactor * cr fixes * Add native plane detection for Android * Add unit tests for android plane detection * Fixes after Code Review Co-authored-by: Paweł Leszkiewicz <pleszkiewicz@users.noreply.github.com> Co-authored-by: darek607 <darekkoniecz@gmail.com> Co-authored-by: Sebastian Paluchiewicz <42351184+SPaluchiewiczSofomo@users.noreply.github.com> Co-authored-by: Grzegorz Dec <grzegorz.dec@blstream.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.