Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2020

Use strict versions for dependencies.
Update LICENSE record.

I think we should also set:

  • author - at this moment it's set to "author" => "author@domain.cn"
    (if we don't want to set email we can set only Magic Leap)
  • version - at this moment it's set to 0.1.0
    (should this reflect npm package version)

@ghost ghost added bug Something isn't working iOS Related to iOS platform. labels Mar 16, 2020
@ghost ghost added this to the 2020.Q1 milestone Mar 16, 2020
@ghost ghost requested review from pleszkiewicz and kpiascik March 16, 2020 08:01
@ghost ghost self-assigned this Mar 16, 2020
Copy link
Contributor

@pleszkiewicz pleszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost
Copy link
Author

ghost commented Mar 16, 2020

@kpiascik due to new version of ChromaColorPicker causes build issue I'm going to merge it without your review - I'll handle your change request in separate PR.

@ghost ghost merged commit a33e423 into master Mar 16, 2020
@ghost ghost deleted the bugfix/#485-updatePodfilePodspec branch March 16, 2020 08:59
darek607 pushed a commit that referenced this pull request Mar 17, 2020
* slider fixes

* min and max order fix for slider and unit tests

* Update Podfile & Podspec. (#486)

* Use strict versions for dependencies.
* Update LICENSE record.

* slider fixes

* min and max order fix for slider and unit tests

Co-authored-by: Sebastian Paluchiewicz <42351184+SPaluchiewiczSofomo@users.noreply.github.com>
ghost pushed a commit that referenced this pull request Apr 14, 2020
* Use strict versions for dependencies.
* Update LICENSE record.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS Related to iOS platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants