Updates to UiDialogNode layout. #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpiascik
reviewed
Nov 2, 2020
| @@ -27,7 +27,8 @@ class DialogView: UIView { | |||
| } | |||
|
|
|||
| static var height: CGFloat { | |||
| return DialogView.width * 0.75 | |||
| let margin: CGFloat = 16.0 | |||
| return max(UIScreen.height, UIScreen.width) - 2 * margin | |||
There was a problem hiding this comment.
won't the height here be a lot bigger now?
There was a problem hiding this comment.
It will, but it does not matter. The height will be reduced by auto-layout. For some reason, it's easier for auto-layout to shrink the view rather than to expand it. I tested it on small and bigger screens (both portrait and landscape) and works fine.
kpiascik
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #604