Introduce FocusIntercepting protocol. #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpiascik
reviewed
Dec 15, 2020
kpiascik
reviewed
Dec 16, 2020
| } | ||
|
|
||
| // Check hit test in a standard way | ||
| var hitResults: [HitTestResult] = [] | ||
| let topNodes: [BaseNode] = rootNode.childNodes.compactMap { $0 as? BaseNode } |
There was a problem hiding this comment.
will this code ever but hit? I think it will only be hit if focusInterceptedNodes is empty.
There was a problem hiding this comment.
That's the goal of this code:
- if there is any component which has intercepted the focus (ex. dropdown List is showing its list), then return that component (so that it can handle the input: either select list item or dismiss the list)
- else do standard hitTest
kpiascik
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem with DropdownList when embedded in any Layout container. After opening the dropdown list, any item cannot be selected because all events are handled by parent component (layout).
To solve this, we introduced FocusIntersecting protocol.
Closes #614 and magic-script/magic-script-components#336