Fix issue #338 - Fixes behaviour if /tmp dir does not exist
#460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mskalski Could you split the two changes into two separate commits, then I am happy to merge that one. |
mskalski
force-pushed
the
termux-tmp-fix
branch
from
eb43e7d to
ab1d44f
Compare
|
@mskalski could you please again change your commits so that the title of the commit is a statement what the commit contains instead of the issue-text. |
…n termux) Private index was tried to create in nonexistent location, no error was ever displayed, and then unconditionally GIT_INDEX_FILE variable was set pointing to nonexistent path. Git used this location and reported many changed files. It is common on Android devices - there is no /tmp directory Termux creates one and sets TMPDIR variable, which is commonly honored by most of unix utilities. Fixes issue magicmonty#338 - Fixes behaviour if `/tmp` dir does not exist
Additionally in case of nonexistent index file (i.e. when `/tmp` does not exist) most of files were marked with 'D' in second loop pass of `gitstatus.sh` which was wrongly identified as 'Stashed'. Now it is idenified as 'changed'
mskalski
force-pushed
the
termux-tmp-fix
branch
from
c52cfbf to
127a44a
Compare
|
@mskalski sorry for being so picky. Find this now merged. Thx for your contribution |
|
Thanks very much for this PR. Works great in my termux instance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private index was tried to create in non-existent location, no error
was ever displayed, and then unconditionally GIT_INDEX_FILE variable
was set pointing to non-existent path. Git used this location and
reported many changed files.
Additionally in case of non-existent index file most of
files were marked with
Din second loop pass ofgitstatus.shwhich was wrongly identified as 'Stashed'.
It is common on Android devices - there is no /tmp directory
Termux creates one and sets
TMPDIRvariable, which is commonlyhonoured by most of unix utilities.