-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a user-ready authentication workflow #4
Comments
On second thought, it would probably be in the better spirit of A possible workflow implementation might be as follows: (defun ghub-authenticate (domain scopes note)
"Authenticates on DOMAIN with SCOPES using NOTE."
(unless (ghub--domain-configuration domain :secure)
(user-error "Refusing to send password over unsafe connection; configure your token in `auth-sources'"))
(let ((ghub-force-basic-authentication t)
(ghub-domain domain)
(user-real-login-name
(ghub--domain-configuration domain :username)))
(ghub-post "/authorizations" nil
`((scopes . ,scopes)
(note . ,note))))) …which reminds me, |
I have merged an alternative implementation. Could you please redo |
Done 👍 |
The authentication workflow is something
gh.el
seems to do very, very well. I like the idea of using existing authentication configuration options, but it would be worthwhile creating an interactive workflow that will guide the user through this configuration when we run into #2.Since it's not wrapping any resources, this seems to be in-scope for
ghub
.The text was updated successfully, but these errors were encountered: