Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Develop-sticky merge"" #210

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

emolinab
Copy link
Contributor

Reverts #208 Needed to merge sticky changes

@abhimishr
Copy link
Member

abhimishr commented Aug 13, 2020

A revert is not needed if something was undocumented. It approves "deletion" of changes which is not correct. Ideally if a file is not commited correctly you can make an additional commit rather than reverting the whole PR (in ref to #199)

@emolinab emolinab merged commit 931d1d5 into develop Aug 13, 2020
@abhimishr abhimishr deleted the revert-208-revert-199-develop_sticky_merge branch August 13, 2020 13:09
@abhimishr
Copy link
Member

This was critical for #211 because the changes needed for @emolinab sticky PR were ignored from the first revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants