Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop sticky documentation fixed #211

Merged
merged 12 commits into from
Aug 14, 2020

Conversation

emolinab
Copy link
Contributor

@emolinab emolinab commented Aug 13, 2020

Purpose of this PR

From the sticky realization PR, it was needed to update the documentation in the default.cfg (include Sticky in the 38_module section) and CHANGELOG.md typos, and to update the test_runs.R script to the last version. This pull request takes care of these issues.

Performance loss/gain from current default behavior

  • N.A.

Type of change

  • Bug fix (Change which fixes an issue).
  • New feature (Change which adds functionality).
  • Minor change (Change which does not modify core model code i.e., in /modules).
  • Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • Runs using starting script which tests current defaults (using test_runs.R).
  • Runs using starting script which successfully runs the same scenarios as in test_runs.R but with the changes from PR.
  • (If applicable) Runs using different scenarios/mappings which are not the default (12 regions/c200 clusters).

Additions or Changes to default configuration (default.cfg):

  • Sticky realization added to the default.cfg documentation.

Changes are deletion or updates to the existing model components in default config

  • Realizations:
  • Scenario switches:
  • Scalars/Constants:
  • Model interfaces:
  • Others:

Checklist:

  • Self-review of my own code.
  • Added changes to CHANGELOG.md
  • No hard coded numbers and cluster/country/region names.
  • The code doesn't contain declared but unused parameters or variables.
  • In-code comments added including documentation comments.
  • [N.A.] Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • [N.A.] Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

@emolinab emolinab changed the title Develop sticky august Develop sticky documentation fixed Aug 13, 2020
@tscheypidi tscheypidi merged commit b41d40e into magpiemodel:develop Aug 14, 2020
@emolinab emolinab deleted the develop_Sticky_August branch February 22, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants