Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the PHP version into a variable #2307

Open
binarykitchen opened this issue Oct 1, 2023 · 1 comment
Open

Place the PHP version into a variable #2307

binarykitchen opened this issue Oct 1, 2023 · 1 comment

Comments

@binarykitchen
Copy link
Contributor

Sooner or later, when upgrading Nextcloud, we will have to upgrade PHP as well.

As a preparation, to make any future PHP upgrades easier, I recommend putting its version into a variable first.

For example:

server unix:/var/run/php/php8.0-fpm.sock;

Should actually come from a variable, like:

server unix:/var/run/php/php{{phpver}}-fpm.sock;

For inspiration, refer to these commits from other forks:

Again, in this ticket, make no PHP upgrades. Just have the PHP version defined in one place only.

binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Oct 1, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
@binarykitchen
Copy link
Contributor Author

PR is here: #2308

binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Oct 1, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Oct 1, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Oct 1, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Oct 1, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
- removes obsolete mail.py
binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Oct 4, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
binarykitchen added a commit to binarykitchen/mailinabox that referenced this issue Dec 19, 2023
Also
- trims a few trailing whitespace characters
- gitignores VS code workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant