Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tailr transformation for cases. #19

Closed
mailund opened this issue Feb 9, 2018 · 1 comment
Closed

Implement tailr transformation for cases. #19

mailund opened this issue Feb 9, 2018 · 1 comment
Assignees
@mailund
Labels
enhancement New feature or request
Milestone
0.1.2

Comments

@mailund
Copy link
Owner

mailund commented Feb 9, 2018

The cases function cannot be used with the tail-recursion implemented in tailr because it looks like a function call, even though it is practically a control structure. By implementing transform_call, I can change that.
@mailund mailund added this to the 0.1.2 milestone Feb 9, 2018
@mailund mailund self-assigned this Feb 9, 2018
@mailund mailund added the enhancement New feature or request label Feb 9, 2018
mailund added a commit to mailund/tailr that referenced this issue Feb 9, 2018
@mailund
Refactored user-transformation in loop_transform
74e1945 
Now I no longer do the user-transformation twice.

If I can now handle mailund/pmatch#19, it will be the last step of #5.
mailund added a commit to mailund/tailr that referenced this issue Feb 9, 2018
@mailund
More progress towards tail-recursive cases
7ff5271 
Progress on #5 and mailund/pmatch#19. I need a non-local `next` when calling recursively in `with` expressions to make this work.
mailund added a commit to mailund/tailr that referenced this issue Feb 9, 2018
@mailund
Exploiting non-local returns
8ac56da 
Using `rlang::return_to` and `rlang::return_from`, I think I now have a solution for handling `with` expressions. This is a step twoards #5 and mailund/pmatch#19 and resolves #7.
mailund added a commit to mailund/tailr that referenced this issue Feb 9, 2018
@mailund
Exploiting non-local returns
2ed2906 
Using `rlang::return_to` and `rlang::return_from`, I think I now have a solution for handling `with` expressions. This is a step twoards #5 and mailund/pmatch#19 and resolves #7.
@mailund
Copy link
Owner Author

mailund commented Feb 28, 2018

I belive this was done with commit d57bc85

@mailund mailund closed this as completed Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mailund mailund

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.2
Development

No branches or pull requests
1 participant
@mailund