Repository navigation
v1.33.1 #64
v1.33.1
#64
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Post-v1.33.0 bugfixes from the fleet deploy. No public API change — PATCH.
Fixed —
mk upgradenow upgrades a group-npm local-dependencyMK_BIN(#340)mk upgrade's installer (shipped in #331) assumed the global layout (MK_BIN = <prefix>/bin/mk→npm install -g --prefix <prefix>). The nanoclaw fleet'sMK_BINis a local dependency (<pkgroot>/node_modules/.bin/mksymlinked intonode_modules/memory-kernel); there the-g --prefix <node_modules>install wrote to<node_modules>/lib/node_modules/…and left the symlinked package — the binary the agent actually runs — untouched (caught byverify-agent-version→ FAIL, never a false PASS, but it didn't upgrade). New pureresolveInstallPlan(mkBin, version)detects the layout: anode_modules/.bin/mkpath → a localnpm install memory-kernel@<ver>run from the owning package root (updates the dep the symlink resolves to); otherwise the global-g --prefixpath (unchanged). +3 tests (test/upgrade-installer.test.ts), including a regression that replicates the group-npm.bin/mk-symlink layout with a fake npm and asserts the symlinked binary truly upgrades (red under the old installer).Fixed — shell scripts run on macOS bash 3.2 (no more
mapfilefalse failures) (#341)scripts/privacy-scan.shandscripts/docs-hygiene-check.shused the bash-4 builtinmapfile, which is absent on the macOS-default/bin/bash3.2 →mapfile: command not found(exit 127) → 28 false test failures for Mac contributors (Linux CI on bash 4+ stayed green). Both now use a portablewhile IFS= read -r x; do arr+=("$x"); done < <(...)loop. Addedtest/shell-portability.test.ts— a static guard that fails if anyscripts/*.shreintroduces a bash-4-only builtin (mapfile/readarray/declare -A/case-conversion expansions); deterministic and CI-meaningful (the existing script tests pass on bash 4+ regardless). Verified clean under/bin/bash3.2.This discussion was created from the release v1.33.1.
All reactions