-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ControlPanel): use SAVE/RESTORE STATE when moving #1988
Conversation
…e commands Signed-off-by: Stefan Dej <meteyou@gmail.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Tested several edge cases:
All tests where PASS so that I would approve the change |
I guess the question now is in terms of value provided: I do think this makes sense, but does it solve a problem or provide new value? The only downside I could see is that it adds a lot of "noise" to the logs... but even that is mitigatable, I think! |
It only brings the "added value" that the previous mode is always set again. Some users, for example, do not have absolute mode in their start macro. We have already had a few support-requests as to "why the printer cannot print after a movement" (out-of-range message). Where you should say, “Please fix your gcode/macros”... So it's a trade-off between “error protection” vs “noise in the console”. |
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas thx for your suggestion! you are complete right. i also opened a PR to rename the gcode_state name in the extruder panel. |
Description
This PR should switch to SAVE_GCODE_STATE/RESTORE_GCODE_STATE to set everytime back to the original movement mode.
Related Tickets & Documents
Comment from @pedrolamas in the extrude panel PR: #1965 (comment)
Mobile & Desktop Screenshots/Recordings
Bildschirmaufnahme.2024-09-01.um.23.56.39.mov
[optional] Are there any post-deployment tasks we need to perform?
none