-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update url-join to the latest version 🚀 #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.0.1 just got published. |
makemek
added a commit
that referenced
this pull request
Apr 22, 2017
makemek
pushed a commit
that referenced
this pull request
Apr 25, 2017
makemek
added a commit
that referenced
this pull request
Apr 25, 2017
Closed
makemek
pushed a commit
that referenced
this pull request
Apr 26, 2017
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
makemek
pushed a commit
that referenced
this pull request
Apr 26, 2017
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
makemek
pushed a commit
that referenced
this pull request
Apr 26, 2017
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
makemek
pushed a commit
that referenced
this pull request
Apr 26, 2017
makemek
added a commit
that referenced
this pull request
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.0.0 of url-join just got published.
The version 2.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of url-join.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 9 commits .
f8961b5
2.0.0
c9e3848
Merge branch 'maxdeviant-patch-1'
9f67671
change copyright year
6243208
Merge branch 'patch-1' of https://github.com/maxdeviant/url-join into maxdeviant-patch-1
071728b
Merge branch 'xtuc-master'
a1e1214
refactor: use local startsWith function
d7053a9
fix: split logic for files
48ebe0d
feat: add file protocol support
ffd3b22
Add a LICENSE file
See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴