Skip to content

code refactor: use array function mapper, add messages param to not_implemented_func() #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 30, 2021
Merged

code refactor: use array function mapper, add messages param to not_implemented_func() #612

merged 8 commits into from
Dec 30, 2021

Conversation

thuydotm
Copy link
Contributor

@thuydotm thuydotm commented Dec 29, 2021 •
edited
Loading

This PR:

  • adds a messages param to not_implemented_func() in order to provide clearer messages in case an array type is not supported for some function.
  • refactors code to use ArrayFunctionMapping in following modules/functions: hillshade, true_color, perlin, slope, terrain, zonal

@thuydotm thuydotm merged commit de0aa50 into master Dec 30, 2021
@ianthomas23 ianthomas23 mentioned this pull request Jan 7, 2022
Closed
6 tasks
This was referenced Feb 7, 2022
Closed
Closed
@thuydotm thuydotm deleted the not_implemented_func branch June 1, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thuydotm