Pass relative URLs for static files through django.contrib.staticfiles (fixes #111) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGES # README.rst # leaflet/__init__.py
| @@ -182,7 +183,8 @@ def _normalize_plugins_config(): | |||
| # absolute URL or a URL starting at root | |||
| pass | |||
| else: | |||
| urls[i] = urljoin(settings.STATIC_URL, url) | |||
There was a problem hiding this comment.
Error on travis: imported but no used :)
There was a problem hiding this comment.
I'll add a new PR
@leplatrem I suggest you add instructions on how to locally run the same test as Travis -- python quicktest.py leaflet --db=postgres (which I had to figure out for myself) passed perfectly. Contributing without knowing the tests is no fun.
There was a problem hiding this comment.
Maybe add 'setup.py test' as default test script, it's not hard
|
I removed the obsolete import of url join. Please add instructions to run local tests that will also pass Travis. |
leplatrem
added a commit
that referenced
this pull request
Sep 7, 2015
Pass relative URLs for static files through django.contrib.staticfiles (fixes #111)
|
I created a dedicated issue for the docs, to prevent blocking the merge of this one :) Thanks a lot for your patience and contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.