-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Leaflet Draw to 0.3.0-dev #153
Conversation
Any argument in favor of merging a «dev» version? |
Aren't we already using a dev version, i.e 0.2.4-dev ? 0.3.0 is just the newest release. |
Great that 0.3 was released! Does this PR embed the tagged version? |
As far as I can remember, yes it does contain the tagged version. |
Hi! May I know if this PR will be merged soon or if there's a timetable for this? |
I was a bit reluctant to embed a dev version to be honest, that's why I didn't merge it immediately. I'd prefer to let @gutard decide... |
Overriding
|
Thanks @raratiru for the feedback! I close the PR, please feel free to re-open with a stable tag of leaflet.draw that works ! |
That's cool, I am glad I helped to delineate the situation. However, it seems that I will not avoid a manual install of leaflet in my effort to work with it on a tablet. |
A simple fix for the error show before : <script type="text/javascript">
L.drawLocal.draw.toolbar.finish = {title:'Finish drawing', text:'Finish'};
</script> |
@RaphaelGeode Thank you for sharing, this is very useful under the current circumstances. |
Thanks for helping out! Do not hesitate open a PR upgrading to Leaflet 1.0 and/or leaflet-draw 0.3.2, it'll be merged if feedback is positive! |
No description provided.