Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Leaflet Draw to 0.3.0-dev #153

Closed
wants to merge 1 commit into from
Closed

Upgrade Leaflet Draw to 0.3.0-dev #153

wants to merge 1 commit into from

Conversation

fanquake
Copy link
Contributor

@fanquake fanquake commented Apr 8, 2016

No description provided.

@leplatrem
Copy link
Collaborator

Any argument in favor of merging a «dev» version?

@fanquake
Copy link
Contributor Author

Aren't we already using a dev version, i.e 0.2.4-dev ? 0.3.0 is just the newest release.

@leplatrem
Copy link
Collaborator

Great that 0.3 was released! Does this PR embed the tagged version?

@fanquake
Copy link
Contributor Author

As far as I can remember, yes it does contain the tagged version.

@leplatrem
Copy link
Collaborator

capture d ecran de 2016-06-30 15-02-55

@seav
Copy link
Contributor

seav commented Jul 30, 2016

Hi! May I know if this PR will be merged soon or if there's a timetable for this?

@leplatrem
Copy link
Collaborator

I was a bit reluctant to embed a dev version to be honest, that's why I didn't merge it immediately. I'd prefer to let @gutard decide...

@raratiru
Copy link

raratiru commented Aug 11, 2016

Overriding leaflet.draw.js in static/leaflet/draw/ with the 0.3.0-dev version in this commit, I receive the following error in the console while leaflet is not working:

TypeError: L.drawLocal.draw.toolbar.finish is undefined
http://127.0.0.1:8000/static/leaflet/draw/leaflet.draw.js
(Line 2991, col. 17)

@leplatrem
Copy link
Collaborator

Thanks @raratiru for the feedback!

I close the PR, please feel free to re-open with a stable tag of leaflet.draw that works !

@leplatrem leplatrem closed this Aug 22, 2016
@raratiru
Copy link

That's cool, I am glad I helped to delineate the situation.

However, it seems that I will not avoid a manual install of leaflet in my effort to work with it on a tablet.

@ghost
Copy link

ghost commented Oct 12, 2016

A simple fix for the error show before :

<script type="text/javascript">
    L.drawLocal.draw.toolbar.finish = {title:'Finish drawing', text:'Finish'};
</script>

@raratiru
Copy link

@RaphaelGeode Thank you for sharing, this is very useful under the current circumstances.

@leplatrem
Copy link
Collaborator

Thanks for helping out!

Do not hesitate open a PR upgrading to Leaflet 1.0 and/or leaflet-draw 0.3.2, it'll be merged if feedback is positive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants