-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support S3 static files storage #58
Conversation
@@ -49,6 +49,8 @@ USAGE | |||
|
|||
* Add ``leaflet`` to your ``INSTALLED_APPS`` | |||
|
|||
* Make sure ``django.contrib.staticfiles`` is also in your ``INSTALLED_APPS``; Django >= 1.3 `includes this by default <https://docs.djangoproject.com/en/1.3/intro/tutorial01/#database-setup>`_ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we add this as a footnote for the very few users still running Django < 1.3 only ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, should I make a new section called "Footnotes"? This INSTALLED_APPS
issue is actually part of why the Travis tests are failing. This does not match the defaults for recent version of Django: https://github.com/makinacorpus/django-leaflet/blob/master/quicktest.py#L22.
Thanks for the contribution ! |
@jnm Any news ? |
@leplatrem, I just had a look at this. There are at least two problems. One is that I'm out of time to work on this today, but perhaps I could resume later in the week. |
Ok, I pushed an updated of the tests and project setup. Thanks for pointing this out :) |
Woohoo! |
Perfect, thanks ! |
Support S3 static files storage
Hello,
This lets
django-leaflet
work in an "advanced use case such as using a cloud service to serve static files," as described in https://docs.djangoproject.com/en/dev/ref/templates/builtins/#static.Thanks for your consideration.