Fix pysamstats #17
Merged
Fix pysamstats #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alimanfoo , I think you need to change final line of .travis.yml to the following - is that right? I was going to commit this to fix-pysamstats-alimanfoo-20181219, but worried it might conflict if you're also changing |
|
Thanks @podpearson, I'll fix that. |
|
OK, CI looks good, going to merge this one. |
|
Btw @podpearson if there is an obvious bug like the one you noticed, please feel free to push a change to the PR branch, if you just leave a comment that you've done so then I'll know to pull before I make any further changes. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades pysam and pysamstats. Also adds an imports test to verify all Python packages can be imported.
Resolves #10. Resolves #13.