add deps to .gitignore #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amakunin
reviewed
Dec 19, 2018
There was a problem hiding this comment.
Hi, @podpearson. Not sure how it should work: conda installation will only work if run as ./binder/install-conda.sh, so the deps folder is always generated outside of binder folder. Meanwhile, it looks reasonable to add deps to gitignore for all repos that have binder as submodule. What do you think?
|
@amakunin yes, you're right, please ignore this pull request. What's the best way to "remove" a pull request? Will deleting the branch do the trick? |
|
Looks like closing pull request then deleting the branch should do the trick |
|
Perfect, thanks @amakunin |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18
Will pull this in tomorrow if no objections