hornet: Replace JVS impl with jvs_host device #10559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JVS code in hornet seems to predate
jvs_hostso I ripped out the old code and replaced it with an equivalent usingjvs_hostto allow for hooking up ajvs_device-based JVS device as well as get rid of some duplicated logic.Gradius 4 with the Master Calendar JVS device as well as a stubbed Windy 2 JVS I/O device (identifies as
KONAMI CO.,LTD.;Windy2;Ver1.0;Windy2 I/O Ver1.0) were used for testing.I also tested gradius4, nbapbp, terabrst, thrilldbu, sscope, sscope2 to make sure they were still booting without a JVS device hooked up.