konami/viper: Fix code1d NVRAM/DS2430, remove duplicate code1da #11844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
einstein95
pushed a commit
to einstein95/mame
that referenced
this pull request
Mar 2, 2024
Also removed code1da as the game content on the disk image is identical to code1d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NVRAM from code1da is a valid NVRAM for GK992 UAD so I moved it to code1d's ROM entry. The expected DS2430 serial for the UAD NVRAM was extracted from the NVRAM data (bytes 0x2a-0x30, reversed) and the serial checksum generated to make a new ds2430_code1d2.u3 that works with the paired NVRAM so no more RTC self-check errors.
code1da was removed because it's just another copy of 922d02. If you extract the two CHDs and mount them as FAT16 then you can find the main ROM file on the filesystem. If you do a checksum comparison of those two files you can see they're identical. The differences in the CHDs seem to come from metadata or other filesystem-related things.