Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tecmo/gaiden.cpp: Add a newer Wild Fang set, may be a year hack #12020

Merged
merged 8 commits into from
Feb 19, 2024

Conversation

clawgrip
Copy link
Contributor

@clawgrip clawgrip commented Feb 8, 2024

New working clone

Wild Fang (year hack?) [Tailsnic Retroworks]

New working machine
-------------------------
Wild Fang (set 1) [Tailsnic Retroworks]
@clawgrip clawgrip marked this pull request as draft February 8, 2024 15:40
@mamehaze
Copy link
Contributor

mamehaze commented Feb 8, 2024

I do find the updated year (2 years newer) on the title screen a little suspicious, as mentioned in private.

While the set is very different to any currently supported set, came from an original PCB and is clearly a previously undumped revision, a leap of 2 years in the copyright date could indicate the string has been hacked.

2 years was a long time in the industry back then and it's uncommon to see dates updated like this.

@clawgrip clawgrip marked this pull request as ready for review February 8, 2024 19:55
@clawgrip
Copy link
Contributor Author

clawgrip commented Feb 8, 2024

48d0d11c-8de2-487b-b8ed-adaa2dac26c6
2d5b6c8b-9549-4458-947b-c6a18e8eea4f

Comment on lines 1326 to 1354
ROM_START( wildfangs ) /* Wild Fang - No title change option */
ROM_REGION( 0x40000, "maincpu", 0 ) /* 2*128k for 68000 code */
ROM_LOAD16_BYTE( "1.3s", 0x00000, 0x20000, CRC(3421f691) SHA1(7829729e2007a53fc598db3ae3524b971cbf49e9) )
ROM_LOAD16_BYTE( "2.5s", 0x00001, 0x20000, CRC(d3547708) SHA1(91cc0575b25fe15d668eec26dd74945c51ed67eb) )
ROM_START( wildfangt ) // Dipswitch selectable title of Wild Fang or Tecmo Knight
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write “DIP switch” in plain English. It isn’t a single word. It’s an abbreviation for “dual inline package switch”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clawgrip: regarding the title screen year, look at the dates on the chips. assuming the dates match previous sets then it's a hack since the EPROM stickers are generic and not official labels. Official labels are square and silver with a thin black border and a single black number in the middle.

Copy link
Contributor Author

@clawgrip clawgrip Feb 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but since there are lot of other changes besides the year (as Haze salid, if it’s a year hack, it’s from a different revision), it’s worth adding.

@cuavas A last word about it? Maybe adding “year hack?” and not adding it as a new parent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, probably a good idea to mark it as a possible hack, and make it a clone for now. We don’t know what else they’ve changed if it’s hacked.

You never know when the version the hack is based on might turn up – the early version of JJ Squawkers with the exploding nuts that the hack on Blandia hardware was based on turned up eventually.

@clawgrip clawgrip marked this pull request as draft February 19, 2024 10:42
@clawgrip clawgrip changed the title tecmo/gaiden.cpp: Add a newer Wild Fang set tecmo/gaiden.cpp: Add a newer Wild Fang set, may be a year hack Feb 19, 2024
@clawgrip clawgrip marked this pull request as ready for review February 19, 2024 13:20
GAME( 1989, wildfangs, wildfang, wildfang, tknight, gaiden_state, init_wildfang, ROT0, "Tecmo", "Wild Fang", MACHINE_SUPPORTS_SAVE )
GAME( 1989, wildfang, 0, wildfang, tknight, gaiden_state, init_wildfang, ROT0, "Tecmo", "Wild Fang / Tecmo Knight", MACHINE_SUPPORTS_SAVE )
GAME( 1989, wildfangs, wildfang, wildfang, wildfang, gaiden_state, init_wildfang, ROT0, "Tecmo", "Wild Fang", MACHINE_SUPPORTS_SAVE )
GAME( 1991, wildfangh, wildfang, wildfang, tknight, gaiden_state, init_wildfang, ROT0, "Tecmo", "Wild Fang (year hack?)", MACHINE_SUPPORTS_SAVE )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverses the input definitions for wildfang and wildfangs – I’m assuming that’s unintentional.

@cuavas cuavas merged commit 78b9d5d into mamedev:master Feb 19, 2024
5 checks passed
@clawgrip clawgrip deleted the patch-15 branch February 19, 2024 15:34
Mokona pushed a commit to Mokona/mame that referenced this pull request Feb 28, 2024
…gram version. (mamedev#12020)

Code is substantially different to other sets, but 1991 year display is suspect and possibly hacked.

New working clones
-------------------------
Wild Fang (year hack?) [Tailsnic Retroworks]
stonedDiscord pushed a commit to stonedDiscord/mame that referenced this pull request Apr 8, 2024
…gram version. (mamedev#12020)

Code is substantially different to other sets, but 1991 year display is suspect and possibly hacked.

New working clones
-------------------------
Wild Fang (year hack?) [Tailsnic Retroworks]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants