Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary backslash line continuation #12047

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

amameuser
Copy link
Contributor

@amameuser amameuser commented Feb 20, 2024

  • devices/*: Remove unnecessary backslash line continuation

  • frontend/*: Remove unnecessary backslash line continuation

  • lib/*: Remove unnecessary backslash line continuation

  • mame/*: Remove unnecessary backslash line continuation

  • osd/*: Remove unnecessary backslash line continuation

  • cpu/m68000/m68000gen.py: Use parentheses in preference to using a backslash for line continuation

  • cpu/m68000/m68000gen.py: Regenerate source files

    m68000gen.py decode m68000.lst m68000-decode.cpp
    m68000gen.py header m68000.lst m68000-head.h
    m68000gen.py sdf m68000.lst m68000-sdf.cpp
    m68000gen.py sdp m68000.lst m68000-sdp.cpp
    m68000gen.py sif m68000.lst m68000-sif.cpp
    m68000gen.py sip m68000.lst m68000-sip.cpp
    m68000gen.py headerm m68000.lst m68000mcu-head.h
    m68000gen.py sdfm m68000.lst m68000mcu-sdfm.cpp
    m68000gen.py sdpm m68000.lst m68000mcu-sdpm.cpp
    m68000gen.py sifm m68000.lst m68000mcu-sifm.cpp
    m68000gen.py sipm m68000.lst m68000mcu-sipm.cpp
    m68000gen.py header8 m68000.lst m68008-head.h
    m68000gen.py sdf8 m68000.lst m68008-sdf8.cpp
    m68000gen.py sdp8 m68000.lst m68008-sdp8.cpp
    m68000gen.py sif8 m68000.lst m68008-sif8.cpp
    m68000gen.py sip8 m68000.lst m68008-sip8.cpp

m68000gen.py decode m68000.lst m68000-decode.cpp
m68000gen.py header m68000.lst m68000-head.h
m68000gen.py sdf m68000.lst m68000-sdf.cpp
m68000gen.py sdp m68000.lst m68000-sdp.cpp
m68000gen.py sif m68000.lst m68000-sif.cpp
m68000gen.py sip m68000.lst m68000-sip.cpp
m68000gen.py headerm m68000.lst m68000mcu-head.h
m68000gen.py sdfm m68000.lst m68000mcu-sdfm.cpp
m68000gen.py sdpm m68000.lst m68000mcu-sdpm.cpp
m68000gen.py sifm m68000.lst m68000mcu-sifm.cpp
m68000gen.py sipm m68000.lst m68000mcu-sipm.cpp
m68000gen.py header8 m68000.lst m68008-head.h
m68000gen.py sdf8 m68000.lst m68008-sdf8.cpp
m68000gen.py sdp8 m68000.lst m68008-sdp8.cpp
m68000gen.py sif8 m68000.lst m68008-sif8.cpp
m68000gen.py sip8 m68000.lst m68008-sip8.cpp
@@ -151,7 +151,7 @@ OBJDIRS = $(OBJ) \
$(OBJ)/tests \
$(OBJ)/tools \
$(OBJ)/prg \
$(OBJ)/generated \
$(OBJ)/generated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for these ones is so that if an item is added or removed at the end of the list, only a single line changes. Without the final continuation backslash, two lines need to change if an item is added or removed at the end of the list.

I don’t particularly like them though, as it’s somewhat error-prone. Removing the blank line after the list will cause bad things to happen.

@cuavas cuavas merged commit 3059568 into mamedev:master Feb 21, 2024
6 checks passed
@amameuser amameuser deleted the misc_fixes_backslashes branch February 21, 2024 11:25
Mokona pushed a commit to Mokona/mame that referenced this pull request Feb 28, 2024
* Removed unnecessary preprocessor line continuations from C++ code.
* Use parentheses to avoid need for line continuations in expressions in Python code.
* Removed line continuations at the end of lists in makefiles.
* cpu/m68000: Regenerated C++ source files.
stonedDiscord pushed a commit to stonedDiscord/mame that referenced this pull request Apr 8, 2024
* Removed unnecessary preprocessor line continuations from C++ code.
* Use parentheses to avoid need for line continuations in expressions in Python code.
* Removed line continuations at the end of lists in makefiles.
* cpu/m68000: Regenerated C++ source files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants