Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New working software list items (apple2_flop_misc.xml) #12073

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Firehawke
Copy link
Contributor


Anti-M (Version 1.9) [4am, Firehawke]
Anti-M (Version 2.0) [4am, Firehawke]
Anti-M (Version 2.1) [4am, Firehawke]
Anti-M (Version 2.2) [4am, Firehawke]

-------------------------------

Anti-M (Version 1.9) [4am, Firehawke]
Anti-M (Version 2.0) [4am, Firehawke]
Anti-M (Version 2.1) [4am, Firehawke]
Anti-M (Version 2.2) [4am, Firehawke]
@Firehawke
Copy link
Contributor Author

Anti-M 1.8 had a set rename; I believe (but can't remember for sure; let's just say that it was an incredibly short-sighted naming choice on my part that I own up to) at the time I set the name, it was believed to be the last version needed. Clearly that hasn't been the case, so no more "antim", all new versions I add will be numbered period.

@peterferrie
Copy link
Member

peterferrie commented Feb 27, 2024 via email

@Firehawke
Copy link
Contributor Author

No, the mistake is on me. No software is ever truly perfect or final.

Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn’t validating because the parent/clone relationships are broken. The latest version should have the short name antim and all the older versions should be marked as clones. The release info element should also be straight YYYYMMDD with no punctuation to match other software lists, to avoid breaking front-ends that depend on it.

@cuavas
Copy link
Member

cuavas commented Mar 1, 2024

GitHub isn’t showing me updates for new commits on this PR, either. Something’s going whacky in the backend.

@cuavas cuavas merged commit f261d52 into mamedev:master Mar 1, 2024
1 of 3 checks passed
stonedDiscord pushed a commit to stonedDiscord/mame that referenced this pull request Apr 8, 2024
New working software list items (apple2_flop_misc.xml)
-------------------------------
Anti-M (version 1.9) [4am, Firehawke]
Anti-M (version 2.0) [4am, Firehawke]
Anti-M (version 2.1) [4am, Firehawke]
Anti-M (version 2.2) [4am, Firehawke]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants