Add console support for KIM-1. #12161

jefftranter · 2024-03-21T00:00:16Z

Adds console support including emulation of hardware character echo.
Serial monitor commands work and I am able to load and run programs like Microsoft Basic.

Is working with a pty but not for on screen console. Hardware loopback is not working quite right yet.

cuavas · 2024-03-23T15:35:26Z

src/mame/commodore/kim1.cpp

+// Called when serial data comes in from console.
+void kim1_state::tty_callback(uint8_t data)
+{
+	// Send data back to terminal to simulate the KIM-1 hardware
+	// echo.
+	m_rs232->write_txd(data);
+}


You’re going to need to AND this with bit 0 of the port B output to avoid issues when they’re both changing at the same time. Also, as this is a write line handler, the parameter type should conventionally be int.

cuavas · 2024-03-23T15:36:36Z

src/mame/commodore/kim1.cpp

+	// Write bit 0 to serial console
+	m_rs232->write_txd(data & 0x01);


You need to keep the state of line in tty_callback and AND it with bit 0 here to avoid issues when they’re both changing at once.

cuavas · 2024-03-23T15:37:12Z

src/mame/commodore/kim1.cpp

 	required_device_array<mos6530_device, 2> m_miot;
 	required_device<pwm_display_device> m_digit_pwm;
 	required_device<cassette_image_device> m_cass;
-	required_ioport_array<3> m_row;
+	required_ioport_array<4> m_row;
 	required_ioport m_special;
+	required_device<rs232_port_device> m_rs232;


Please keep the devices together rather than mixing them with the I/O ports.

cuavas · 2024-03-23T15:37:55Z

src/mame/commodore/kim1.cpp


 	int m_sync_state = 0;
 	bool m_k7 = false;
+	uint8_t m_u2_port_a = 0;


Why did you add this data member? It doesn’t appear to be used for anything.

cuavas · 2024-03-23T15:38:39Z

src/mame/commodore/kim1.cpp


 #include "kim1.lh"

-
 namespace {



Please restore the two blank lines between sections.

cuavas · 2024-03-23T15:38:59Z

src/mame/commodore/kim1.cpp

 }

+static DEVICE_INPUT_DEFAULTS_START(terminal)
+	DEVICE_INPUT_DEFAULTS("RS232_RXBAUD", 0xff, RS232_BAUD_2400)
+	DEVICE_INPUT_DEFAULTS("RS232_TXBAUD", 0xff, RS232_BAUD_2400)
+	DEVICE_INPUT_DEFAULTS("RS232_DATABITS", 0xff, RS232_DATABITS_8)
+	DEVICE_INPUT_DEFAULTS("RS232_PARITY", 0xff, RS232_PARITY_NONE)
+	DEVICE_INPUT_DEFAULTS("RS232_STOPBITS", 0xff, RS232_STOPBITS_2)
+DEVICE_INPUT_DEFAULTS_END

 //**************************************************************************


Please restore the two blank lines between sections here, too.

cuavas · 2024-03-23T15:39:22Z

src/mame/commodore/kim1.cpp

 }

+// Called when serial data comes in from console.
+void kim1_state::tty_callback(uint8_t data)
+{
+	// Send data back to terminal to simulate the KIM-1 hardware
+	// echo.
+	m_rs232->write_txd(data);
+}

 //**************************************************************************


Please restore the two blank lines between sections here, too.

cuavas · 2024-03-23T15:44:43Z

src/mame/commodore/kim1.cpp

- add TTY support
+- Make console toggle a DIP switch?


What is it physically? If it isn’t a DIP switch, it should not be a DIP switch in MAME. Did you choose IPT_KEYBOARD just so it could easily be enabled/disabled in the Keyboard Selection menu when you want to use the terminal keyboard?

Speaking of which, is the reason the terminal isn’t “working” because you have multiple devices with keyboard inputs in the system and the terminal keyboard isn’t enabled? MAME only enables the first keyboard in the system by default so you aren’t typing on all the keyboards at once. (go to main menu, Input Settings, Keyboard Selection to enable/disable keyboards).

…console

jefftranter · 2024-04-14T20:34:55Z

The MR was updated to address the review comments.

…ix consistently, add new members to save states.

x48x4b · 2024-08-06T06:48:14Z

Adds console support including emulation of hardware character echo. Serial monitor commands work and I am able to load and run programs like Microsoft Basic.

Hi & thank you!

I started KIM-1 on my Linux (Fedora 39 on a Intel core i5 machine) box with
./mame kim1 -rs232 pty -resolution 800x600 -window
In the "Machine Configuration" I set the serial paramters to "300 baud no parity 1 stop bit".
I connected with
minicom -p /dev/pts/0 -b 300 -8

So far everything is fine and I can connect to the KIM-1 console as designed.

However, loading a papertape file with "L" and sending the *.pap file with minicom is not stable. If I send a short file this is okay, if I send a long file it does not work properly, even when setting character and line feed delays in minicom (20ms/200ms).

Best regards

x48x4b · 2024-08-07T18:44:44Z

Adds console support including emulation of hardware character echo. Serial monitor commands work and I am able to load and run programs like Microsoft Basic.

Hi & thank you!

I started KIM-1 on my Linux (Fedora 39 on a Intel core i5 machine) box with
./mame kim1 -rs232 pty -resolution 800x600 -window

In the "Machine Configuration" I set the serial paramters to "300 baud no parity 1 stop bit".

I connected with
minicom -p /dev/pts/0 -b 300 -8

So far everything is fine and I can connect to the KIM-1 console as designed.

However, loading a papertape file with "L" and sending the *.pap file with minicom is not stable. If I send a short file this is okay, if I send a long file it does not work properly, even when setting character and line feed delays in minicom (20ms/200ms).

Best regards

With the following setup I was able to load the Basic interpreter papertape file and run it:
./mame kim1 -sl1 mtuk1016 -rs232 pty
Therefore, I conclude that yesterday, I did not load sufficient memory.

jefftranter added 2 commits March 20, 2024 19:58

Add console support for KIM-1.

8df3f24

Is working with a pty but not for on screen console. Hardware loopback is not working quite right yet.

Console echo is now working correctly.

d2f0ad2

jefftranter marked this pull request as ready for review March 23, 2024 00:01

cuavas requested changes Mar 23, 2024

View reviewed changes

jefftranter added 3 commits April 14, 2024 15:51

Merge branch 'mamedev:master' into kim1_console

ea4dc54

Address review comments.

47fa83a

Merge branch 'kim1_console' of github.com:jefftranter/mame into kim1_…

342d176

…console

commodore/kim1.cpp: Avoid implicit bool-to-int conversion use m_ pref…

47c4d88

…ix consistently, add new members to save states.

cuavas merged commit f6d6f06 into mamedev:master Apr 15, 2024
2 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add console support for KIM-1. #12161

Add console support for KIM-1. #12161

jefftranter commented Mar 21, 2024 •

edited

Loading

cuavas Mar 23, 2024

cuavas Mar 23, 2024

cuavas Mar 23, 2024

cuavas Mar 23, 2024

cuavas Mar 23, 2024

cuavas Mar 23, 2024

cuavas Mar 23, 2024

cuavas Mar 23, 2024

jefftranter commented Apr 14, 2024

x48x4b commented Aug 6, 2024

x48x4b commented Aug 7, 2024

		// Write bit 0 to serial console
		m_rs232->write_txd(data & 0x01);

Add console support for KIM-1. #12161

Add console support for KIM-1. #12161

Conversation

jefftranter commented Mar 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jefftranter commented Apr 14, 2024

x48x4b commented Aug 6, 2024

x48x4b commented Aug 7, 2024

jefftranter commented Mar 21, 2024 •

edited

Loading