-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mr/nl_drlibling.cpp: Fixed the PARATA netlist and optimized performance #12180
Conversation
@cuavas gentle ping. |
Video proof that no pac-man sound comes out when players move (the video on youtube comes from a weird bootleg or different ROM) HAPPY EASTER TO WHOEVER CELEBRATES IT. |
Further improvements: put all netlists behind FRONTIER. This gives enough performance to play the parata audio and further improvements. |
One more performance improvement, using an idea from @cuavas description of the second JFET (isolation purposes). |
@rb6502 gentle ping |
I'm not super qualified to review netlist code beyond the obvious style stuff. That all looks fine, and I like that you've got the graphs to show the improved accuracy, but I'm going to give @cuavas a day or two to recover from the release and take a look before I commit this. I don't know if we've got any other drivers that could use some netlist work off the top of my head, but I'd love to see you do more in this area. |
@rb6502 more than willing to help with other netlists needing work, but kind of hard for me if the feedback loop takes really long since I have the attention span of a gold fish. |
Hi @rb6502 pinging back. |
@cuavas
I finally found a way to have enough perf to emulate the PARATA netlist correctly.
After regenerating the static solvers, this one works quite well.
Possible improvement: put more sounds behind
OPTIMIZE_FRONTIERS
, I couldn't figure out how to do it.With a little bit of effort, this can make the 0.264 release.P.S. of course static solvers will need to be regenerated.