Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igs/igs036crypt.cpp: added preliminary decryption for bubucar [XingXing] #12187

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

HappyASR
Copy link
Contributor

No description provided.

@galibert galibert merged commit 4d166f4 into mamedev:master Mar 27, 2024
5 checks passed
@cuavas
Copy link
Member

cuavas commented Mar 27, 2024

Hang on, this isn’t hooked up to anything – it’s just an unreferenced extern array in a source file that isn’t even declared in the corresponding header. This needs corresponding changes in igs036crypt.h and igs_m036.cpp. Also, the comment about the reliability of the keys in igs036crypt.cpp needs to be updated if this key is only “preliminary”.

@HappyASR
Copy link
Contributor Author

Sorry for confusion.

Those IGS036/IGS027 keys are only for informational purposes. They should be included in comments or separate binary files, as someone might need them to decrypt the ROM and trojan the internal code.

The game won't boot without the internal code, and the internal code is responsible for uploading those keys to the decryption hardware, so those keys become useless for the final emulation.

Regarding reliability, I'm pretty sure this table will produce 100% correct results for this game.

@HappyASR HappyASR deleted the HappyASR-patch-1 branch March 28, 2024 01:45
@mamehaze
Copy link
Contributor

mamehaze commented Mar 30, 2024

right, to clarify, for the games where the internal ROM is dumped, the tables get uploaded (by the internal ROM, from the internal ROM), and MAME handles it that way.

all the emulated games using an 036 CPU already have the internal ROM dumped at this point, so the offline decryption functions were removed at some point.

however, as HappyASR says, if somebody wants to trojan the game, they'll need this information to decrypt the ROM in order to modify it, so the information here is useful.

I don't think there is anybody active who can do the trojanning process though, that was a Peter + Morten setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants