Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igs/pgm.cpp: fix chinese spelling in multiple descriptions #12206

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

barbudreadmon
Copy link
Contributor

A chinese friend was telling me "chuan" is incorrect for those descriptions, it should be "zhuan".

@barbudreadmon
Copy link
Contributor Author

further explanations :

传 (傳), a Chinese character at the first level, pronounced as chuán or zhuàn, a morpheme first found in the oracle bone inscriptions. The original meaning is to pass on, to transmit. Derived from this meaning, it means to pass on, to keep and pass on. When read as zhuàn, it has the meanings of a post station, a post house, a text recording historical events or personal deeds, a literary work or a work explaining scriptures.

Due to the context of those games (historical events), it should be zhuan.

@taoenwen
Copy link

taoenwen commented Apr 3, 2024

Among mame's reviewers, this issue is not so conspicuous, but it is so simple that if ten minutes is not enough, I believe that more time is not necessarily effective, and at the moment when you are sure of the finalization of the draft, do you want to leave some time for you to leave down the omission.

@cuavas cuavas merged commit 4cf3915 into mamedev:master Apr 3, 2024
@barbudreadmon barbudreadmon deleted the patch-1 branch April 3, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants