Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine/icd2061a: Fix out of bounds array access #12207

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

987123879113
Copy link
Contributor

Just to be sure I checked and all other usages of m_reg_clocks are using constants instead of variables. truckk and ujlnow are both still booting so code-wise it's working as expected (they rely on the feature clock working properly to even boot).

cc: @happppp

@happppp
Copy link
Member

happppp commented Apr 2, 2024

Should it keep the clock unchanged if select = VCLKOUT_FORCED_HIGH or VCLKOUT_HIGH_Z?

@987123879113
Copy link
Contributor Author

There's a TODO for those clock settings in the header of the file. I never found anything that used those so they're left unimplemented since I didn't want to implement it if I couldn't test it.

@987123879113 987123879113 marked this pull request as draft April 2, 2024 12:15
@987123879113 987123879113 marked this pull request as ready for review April 2, 2024 12:18
@987123879113
Copy link
Contributor Author

Added in a logger for TODOs and made it print out a message if it encounters one of the unimplemented clock settings instead of silently ignoring it entirely.

@happppp happppp merged commit 092e75b into mamedev:master Apr 2, 2024
5 checks passed
@987123879113 987123879113 deleted the fix_icd2061a_overflow branch April 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants