itech/itech8.cpp: Various cleanups #12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce unnecessary lines Reduce preprocessing defines Constantize variables Use correct typename values Use C++ style comment for single line comments Use palette_device for grmatch color behaviour Remove unpopulated device Fix filename comments Use input_merger for FIRQ with VIA Use machine().side_effect_disabled() for avoid debugger issue
cuavas
reviewed
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce unnecessary lines
Reduce preprocessing defines
Constantize variables
Use correct typename values
Use C++ style comment for single line comments
Use palette_device for grmatch color behaviour
Remove unpopulated device
Fix filename comments
Use input_merger for FIRQ with VIA
Use machine().side_effect_disabled() for avoid debugger issue
Replace pointers to references
Fix spacing in metadatas