midway/midtunit.cpp, midtunit_v.cpp, midwunit.cpp, midxunit.cpp: Cleanups #12281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nups midtunit_v.cpp: Use devcb_write_line for DMA IRQ handling Reduce hardcoded tags Reduce unnecessary DUMMY_TAG Initialize variables in constructor Constantize variables Use logmacro.h for logging Fix function name midtunit.cpp: Split class related to sound system Reduce defines Reduce literal tag usage Use logmacro.h for logging Fix function name Suppress side effects for debugger read Reduce unnecessary functions Reduce unnecessary finders midwunit.cpp: Reduce defines Constantize variables Reduce literal tag usages Suppress side effects for debugger read Fix function naming Reduce unnecessary finders midxunit.cpp: Reduce defines Constantize variables Reduce literal tag usages Suppress side effects for debugger read Fix function naming
…_state::sound_state_r return when side effects disabled, sort #includes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
midtunit_v.cpp:
Use devcb_write_line for DMA IRQ handling
Reduce hardcoded tags
Reduce unnecessary DUMMY_TAG
Initialize variables in constructor
Constantize variables
Use logmacro.h for logging
Fix function name
midtunit.cpp:
Split class related to sound system
Reduce defines
Reduce literal tag usage
Use logmacro.h for logging
Fix function name
Suppress side effects for debugger read
Reduce unnecessary functions
Reduce unnecessary finders
midwunit.cpp:
Reduce defines
Constantize variables
Reduce literal tag usages
Suppress side effects for debugger read
Fix function naming
Reduce unnecessary finders
midxunit.cpp:
Reduce defines
Constantize variables
Reduce literal tag usages
Suppress side effects for debugger read
Fix function naming