seta/downtown.cpp: Cleanups #12359
Merged
seta/downtown.cpp: Cleanups #12359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cam900
commented
May 10, 2024
cam900
commented
- Use logmacro for logging functions
- Split driver class related to Tilemap chip, X1-010 soundchip
- Use C++ style comments for single line comments
- Fix naming for ROM region and shared RAM tags
- Reduce literal tag usages
- Fix PCMMUTE bit for calibr50
- Suppress side effects for debugger reads
- Use logmacro for logging functions - Split driver class related to Tilemap chip, X1-010 soundchip - Use C++ style comments for single line comments - Fix naming for ROM region and shared RAM tags - Reduce literal tag usages - Fix PCMMUTE bit for calibr50 - Suppress side effects for debugger reads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.