heathzenith/h89.cpp: Add wait states for mms 77316 fdc #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Jul 29, 2024
Comment on lines
-136
to
145
| if (burstMode()) | ||
| if (burst_mode_r() && !m_drq && !m_irq) | ||
| { | ||
| // TODO add wait states in burst mode, currently blocked on Z80 properly supporting wait states | ||
| LOGBURST("%s: burst_mode\n", FUNCNAME); | ||
| LOGBURST("%s: burst_mode setting wait state\n", FUNCNAME); | ||
| m_wait_cb(ASSERT_LINE); | ||
|
|
||
| return(0x00); | ||
| } |
There was a problem hiding this comment.
I suspect this will wreak havoc with the debugger as it’s a read with side effects.
There was a problem hiding this comment.
Thanks for catching that. I'll try to get a PR open tonight to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 77316 FDC requires wait states to work with 8" DD disks, since the 2 MHz Z80 could not handle the data rate of 8" DD disks. The hardware on the card will hold the CPU in wait states until the DRQ state is raised.
Reading and writing is now working correctly with the latest comit.