machine/ncr5385.cpp: raise IRQ for INT_INVALID_CMD #12524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Elektraglide
commented
Jun 28, 2024
Elektraglide
commented
- Tek4404 issues cmd=0xff which expects an IRQ even though its an INT_INVALID_CMD
- minor readability; replaced magic hex value with symbolic names
rb6502
reviewed
Jun 28, 2024
rb6502
reviewed
Jun 28, 2024
| @@ -816,7 +817,9 @@ void ncr5385_device::set_dreq(bool dreq) | |||
|
|
|||
| void ncr5385_device::update_int() | |||
| { | |||
| bool const int_state = m_int_status & 0x5f; | |||
| bool const int_state = m_int_status & (INT_FUNC_COMPLETE | INT_BUS_SERVICE | | |||
|
Also, please give the pull request a meaningful title. What does it change? What does it fix? |
Elektraglide
changed the title
Title amended. In large code base like this, I've generally used PR titles to give 'area of interest' for reviewers and used following lines to explain the details. But if having a detailed title is the MAME thang, happy to go with it. :-) |
rb6502
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.