Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heath/Zenith H8: Add Front Panel Keypad and Support for Serial Console #12590

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jefftranter
Copy link
Contributor

Add front panel keypad and support for serial console to Heathkit H8.

@rb6502
Copy link
Contributor

rb6502 commented Jul 18, 2024

The actual code looks fine to me. @cuavas is there a better/less verbose way to accomplish what the layout file is doing?

@rb6502 rb6502 merged commit 8f82bd0 into mamedev:master Jul 26, 2024
5 checks passed
@cuavas
Copy link
Member

cuavas commented Jul 30, 2024

This has the same issues as #12053 and more.

@cuavas
Copy link
Member

cuavas commented Jul 30, 2024

Also, given the UART is optional, shouldn’t there be an option to run without it?

@mgarlanger
Copy link
Contributor

The optional H-8-5 board was the first serial board Heath offered. It contains two 8251 UARTs, one for the cassette port and one for the console port. Since the existing code doesn't have the cassette 8251 as optional, this change doesn't really make the H8 code any worse. Later, Heath offered the H-8-4 serial board, which provided four 8250 UARTs.

Ideally, the H8 would have slots for its bus, and both of these serial boards would be implemented as virtual cards which could then be selected by the user.

Actually, the H8 bus is a passive bus, and everything including the CPU board should be on a card (and selectable) since Heath (and other companies) offered Z80 replacement CPU cards.

I've been working with @rb6502 to add slots to the H89, and once that is working, I planned to see what it would take to get slots added to the H8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants