hp/hp98x6.cpp: Support 3 new machines #12599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a quick scroll through it. Looks pretty good to me, just a few feedback points that popped into my head, but I don't feel strongly enough about them that devs with commit access should hold things up about it:
|
cuavas
reviewed
Jul 20, 2024
src/mame/hp/hp98x6.cpp
Outdated
Comment on lines
127
to
131
| class hp98x6_base_state : public driver_device | ||
| { | ||
| public: | ||
| hp9816_state(const machine_config &mconfig, device_type type, const char *tag) | ||
| hp98x6_base_state(const machine_config &mconfig, device_type type, const char *tag) | ||
| : driver_device(mconfig, type, tag) |
There was a problem hiding this comment.
If this is now an abstract base class, the constructor should be protected.
src/mame/hp/hp98x6.cpp
Outdated
Comment on lines
1018
to
1019
| floppy_image_device *drives[2] = { get_drive(0), get_drive(1) }; | ||
| floppy_image_device *new_floppy = drives[get_sel_floppy()]; |
There was a problem hiding this comment.
Wouldn’t it be simpler to just do:
floppy_image_device *const new_floppy = get_drive(get_sel_floppy());There was a problem hiding this comment.
absolutely, that was a relic from an early implementation
rb6502
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds the emulation of hp9826a, 9836a & 9836c machines (of the hp98x6 family).
I'll e-mail the relevant ROM images shortly.
Thanks.
--F.Ulivi