-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new NOT WORKING machines (Disney Classic Handheld Karaoke Player) #12606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
------------------------ Disney Classic Handheld Karaoke Player (DKS7000-C) [Sean Riddle, David Haywood] new NOT WORKING software list entries ------------------------------------- easy_karaoke_cart.xml dkp2: Disney Princess 10-Song Karaoke Cartridge II (DK-P2) [Sean Riddle, David Haywood] dkp3: Disney Princess 10-Song Karaoke Cartridge III (DK-P3) [Sean Riddle, David Haywood] (also removed the parent/clone relationships from most of these, as they're distinct products in reality)
cuavas
reviewed
Jul 27, 2024
Comment on lines
+541
to
+565
A Spoonful of Sugar Mary Poppins | ||
A Whole New World Disney | ||
Bare Necessities The Jungle Book | ||
Be Our Guest Beauty and the Beast | ||
Bibbidi-Bobbidi-Boo Disney | ||
Can You Feel The Love Tonight The Lion King | ||
Chim Chim Cheree Disney | ||
Circle of Life The Lion King | ||
Colors of the Wind Pocahontas | ||
Cruella De Vil 101 Dalmations | ||
Hakuna Matata The Lion King | ||
I Just Can't Wait To Be King The Lion King | ||
I Wan'na Be Like You (The Monkey Song) The Jungle Book | ||
I Won't Say (I'm In Love) Hercules | ||
I'll Make A Man Out Of You Mulan | ||
If I Didn't Have You Monsters Inc. | ||
It's A Small World New York World's Fair | ||
Kiss The Girl The Little Mermaid | ||
Part Of Your World The Little Mermaid | ||
Supercalifragilisticexpialidocious Disney | ||
Yo Ho! (A Pirate's Life For Me) Pirates of the Caribbean | ||
You Can Fly! You Can Fly! You Can Fly! Peter Pan | ||
You'll Be In My Heart Tarzan | ||
You've Got A Friend In Me Toy Story | ||
Zip-A-Dee-Do-Dah Song of the South |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do some songs just list Disney and not the film? (A Whole New World from Aladdin Bibbidi-Bobbidi-Boo from Cinderella, etc.)
That's just how they list them; probably using metadata from whatever they
converted, or maybe a copyright database
…On Sat, 27 Jul 2024, 20:44 Vas Crabb, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/mame/skeleton/easy_karaoke.cpp
<#12606 (comment)>:
> +A Spoonful of Sugar Mary Poppins
+A Whole New World Disney
+Bare Necessities The Jungle Book
+Be Our Guest Beauty and the Beast
+Bibbidi-Bobbidi-Boo Disney
+Can You Feel The Love Tonight The Lion King
+Chim Chim Cheree Disney
+Circle of Life The Lion King
+Colors of the Wind Pocahontas
+Cruella De Vil 101 Dalmations
+Hakuna Matata The Lion King
+I Just Can't Wait To Be King The Lion King
+I Wan'na Be Like You (The Monkey Song) The Jungle Book
+I Won't Say (I'm In Love) Hercules
+I'll Make A Man Out Of You Mulan
+If I Didn't Have You Monsters Inc.
+It's A Small World New York World's Fair
+Kiss The Girl The Little Mermaid
+Part Of Your World The Little Mermaid
+Supercalifragilisticexpialidocious Disney
+Yo Ho! (A Pirate's Life For Me) Pirates of the Caribbean
+You Can Fly! You Can Fly! You Can Fly! Peter Pan
+You'll Be In My Heart Tarzan
+You've Got A Friend In Me Toy Story
+Zip-A-Dee-Do-Dah Song of the South
Why do some songs just list Disney and not the film? (A Whole New World
from Aladdin Bibbidi-Bobbidi-Boo from Cinderella, etc.)
—
Reply to this email directly, view it on GitHub
<#12606 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBR6GZP6QHDR5E7ZUDZMIEDZOP2A7AVCNFSM6AAAAABLIJJ2FSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBTGIZDMOJUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new NOT WORKING machines
Disney Classic Handheld Karaoke Player (DKS7000-C) [Sean Riddle, David Haywood]
new NOT WORKING software list entries
easy_karaoke_cart.xml
dkp2: Disney Princess 10-Song Karaoke Cartridge II (DK-P2) [Sean Riddle, David Haywood]
dkp3: Disney Princess 10-Song Karaoke Cartridge III (DK-P3) [Sean Riddle, David Haywood]
(also removed the parent/clone relationships from most of these, as they're distinct products in reality)