Improved reset, timer and port C behaviour #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
requested changes
Nov 30, 2016
| @@ -20,7 +20,7 @@ | |||
| * - Complete support for clock and timers | |||
| * - Add interrupt support | |||
| * - Add DMA support | |||
| * - Add double buffering for each submode | |||
| * - Add apropriate buffering for each submode | |||
There was a problem hiding this comment.
Can you fix the spelling to save Tafoid's blood pressure? ;)
There was a problem hiding this comment.
Roger that! I know that can be a problem, more exercise is good my doctor said and indeed :)
|
|
||
| void pit68230_device::update_tin() | ||
| { | ||
| static uint32_t counter = 0; |
There was a problem hiding this comment.
This can't possibly be right - how can there be one of these for all instances of the device? Function statics are also a problem for when we want to be able to run multiple machines in the future.
There was a problem hiding this comment.
Yeah, its wip and wrong I know, but will fix it, stay tuned.
…IN pin clock update interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some features that is needed for the micro20 selftest but couldn't hook up the missing parts so haven't verified that the self test actually can run through now. Improvements:
The test expects something to pulse at port B and then a clock at TIN (port C pin #2 alternate function)