Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bus/nes: Added support for Chinese translations of Genghis Khan, Squa… #9569

Merged
merged 1 commit into from Apr 15, 2022

Conversation

0kmg
Copy link
Contributor

@0kmg 0kmg commented Apr 14, 2022

…re's Tom Sawyer, and Tenchi wo Kurau II.

Software list items promoted to working (nes.xml)

Dàtáng Fēngyún VI Dài (China)
Chéngjísīhán (China)
Fēngsè Huànxiǎng (China)
Tāngmǔ Lìxiǎn Jì (China)
Tenchi wo Kurau II - Shokatsu Koumei Den (China)
Tenchi wo Kurau II - Shokatsu Koumei Den (China, alt)
Tūnshí Tiāndì II (China)
Tūnshí Tiāndì II (China, alt)
Tūnshí Tiāndì II (China, alt 2)
Tūnshí Tiāndì III (China)

…re's Tom Sawyer, and Tenchi wo Kurau II.

Software list items promoted to working (nes.xml)
---------------------------------------
Dàtáng Fēngyún VI Dài (China)
Chéngjísīhán (China)
Fēngsè Huànxiǎng (China)
Tāngmǔ Lìxiǎn Jì (China)
Tenchi wo Kurau II - Shokatsu Koumei Den (China)
Tenchi wo Kurau II - Shokatsu Koumei Den (China, alt)
Tūnshí Tiāndì II (China)
Tūnshí Tiāndì II (China, alt)
Tūnshí Tiāndì II (China, alt 2)
Tūnshí Tiāndì III (China)
@0kmg
Copy link
Contributor Author

0kmg commented Apr 14, 2022

The bottom six items listed above are all variants of Tenchi wo Kurau II. I left the descriptions somewhat as they were before, save for obviously incorrect things like one or the other being in simplified or traditional script. I can't tell you anything about them except they appear identical and differ in relatively few bytes. It's probably the case that there are a couple of genuine carts represented there, but I can't possibly sort them out any more than this at this point.

@0kmg
Copy link
Contributor Author

0kmg commented Apr 14, 2022

Also, note there's a change in the general MMC3 code to a sneaky line that had writes to extra work RAM going to both the battery and non-battery-backed RAM. I don't think there are any MMC3 (or clone) games with both types of RAM so this change should be okay™. The parallel read function returns only one or the other for obvious reasons, so it also makes sense to have the default write behavior be the same. (There are also other instances of this dual RAM write issue in the NES slot code that should be cleaned up but are probably harmless at the moment due to the rarity of boards with multiple types of work RAM.)

@rb6502 rb6502 merged commit 2aeed0b into mamedev:master Apr 15, 2022
@0kmg 0kmg deleted the nes-mappers-198,199 branch April 15, 2022 03:51
wilbertpol pushed a commit to wilbertpol/mame that referenced this pull request Apr 22, 2022
…re's Tom Sawyer, and Tenchi wo Kurau II. (mamedev#9569)

Software list items promoted to working (nes.xml)
---------------------------------------
Dàtáng Fēngyún VI Dài (China)
Chéngjísīhán (China)
Fēngsè Huànxiǎng (China)
Tāngmǔ Lìxiǎn Jì (China)
Tenchi wo Kurau II - Shokatsu Koumei Den (China)
Tenchi wo Kurau II - Shokatsu Koumei Den (China, alt)
Tūnshí Tiāndì II (China)
Tūnshí Tiāndì II (China, alt)
Tūnshí Tiāndì II (China, alt 2)
Tūnshí Tiāndì III (China)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants