Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java additions #936

Merged
merged 15 commits into from
Feb 17, 2024
Merged

Java additions #936

merged 15 commits into from
Feb 17, 2024

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Oct 23, 2023

No description provided.

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick look found some issues. I haven't gone in depth on the structs (but they look correct) or on the sem_trywait() implementation yet.

abis/linux/ioctls.h Outdated Show resolved Hide resolved
abis/linux/input.h Outdated Show resolved Hide resolved
options/linux/include/linux/input.h Outdated Show resolved Hide resolved
options/posix/generic/search.cpp Outdated Show resolved Hide resolved
options/posix/include/search.h Outdated Show resolved Hide resolved
options/linux/meson.build Outdated Show resolved Hide resolved
@Qwinci Qwinci force-pushed the java branch 2 times, most recently from 2215a53 to a436fd9 Compare October 23, 2023 21:50
@Qwinci
Copy link
Contributor Author

Qwinci commented Oct 23, 2023

I changed those, installing the partial linux/input.h header also created build issues.

Add IPV6_{RECVTCLASS,TCLASS} and MCAST_{UN,}BLOCK_SOURCE
Add SIOCGIFBRDADDR and SIOCGIFNETMASK ioctls.
Add a name to sigjmp_buf struct, because there are some instances when it being unnamed gives errors.
@Qwinci
Copy link
Contributor Author

Qwinci commented Feb 16, 2024

I removed the hsearch family of functions from this pr in favor of #941.

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

options/posix/include/unistd.h Outdated Show resolved Hide resolved
options/glibc/include/netinet/icmp6.h Outdated Show resolved Hide resolved
Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. This should be fine to merge into master instead of abi-break, the detected break is only about renaming a struct.

@no92 no92 merged commit c96114c into managarm:master Feb 17, 2024
29 of 30 checks passed
@Qwinci Qwinci deleted the java branch February 17, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants