-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project name change request #75
Comments
The nice thing is that the entire library is represented by a single .rb file - changing the name if you don't like it is a single I am very much against renaming projects for political reasons - developer efficiency, muscle memory, all the code this will break, etc, are much more important. Just another POV~ |
I'm not a fan of the name myself, FWIW, but we inherited it and it's being used by many projects. I use the argument from the FAQ that it's "troll option parser", but I readily admit that is pretty weak. Any ideas on new names? Would troll_op work for everyone, or should we just pick a completely new name? I'm curious what others think. |
I know this has laid dormant for 5 months, but it's still open so I thought I'd chime in since this actually came up at |
@Fryguy I leave this in your court. Back when this was written, so many gems had "clever" (read: offensive) names. But how can one just rename a gem that is downloaded 10's of millions of times and been out for over 10 years? |
It's happened before: cut a new X release under the new name, and a new Z release under the old name with clear documentation that a project is dead/old/deprecated and new work will be happening under the new name/new repo. What I think would really matter is what folks might encounter on the Rubygems page and what information they received when they run I concede that it's not easy and that folks will continue to point at the old name/install the old gem (maybe forever) but it's work worth doing. Since Trollop is an open source project, I don't think it's out of line for users to expect/encounter some small degree of friction. Of course, I also say this without the onus of maintainership so my opinions are just 🙈 🙉 at best. |
(BTW thank you to both @Fryguy and @kbrock for the work you've put into maintaining Trollop and updating it. I know I'm pushing pretty hard for a rename being the right thing to do, but you've both done a ton for this project and your work has been appreciated. I'm happy to defer to what you think is best since you're the ones carrying the onus of maintainership here.) |
Hi, I just came here after this started showing up in our Gemfile.lock. I also wanna thank you for your work maintaining this but also ecnourage you to change the name. @mckern drew up a good blueprint on how to do that. I'd really appreciate the effort to do that and would also volunteer some of my time to help with the name migration. Also, in hopes for a ruby community without offensive gem names :) Cheers, |
I don't think the issue is the logistics of renaming the gem, but instead is just coming up with a name. |
I actually have a local fork that I'd worked through renaming with; I called it |
I'd prefer to have 'opt' or 'option' as part of the name if possible. it makes it a little easier to deduce what's going on from the require. That's english speaker bias though. Some cheesy thoughts:
too bad optopus was already taken |
|
Is there a release planned in the immediate future (I would be keen on the new #ignore_invalid_options behaviour)? I guess the rename could just happen then and there. |
OptionIQ or OptIQ? |
I find optane the best and most original pun. Usually, option parsing library names are so boring. Hopefully we get more "options" and can vote on it. |
@jrafanie how about "Mops" for 'more options' |
Trollipop. It's similar, but different, and you can sing to it to the Chordettes song. :) |
Trollipop actually made me laugh. 😆 Even so, my vote is for optane so far. |
heh. yes, that is amusing. |
I like |
trollop backwards |
@macosgrove @Fryguy Looks like Optane is trademarked and in a related field. Maybe not such a good idea after all. For the sake of positive feels, |
@Fryguy |
Naming is hard. Maybe |
Welp, since it seems everyone is bent on doing this, have acronyms been considered?
Could even make it sound like an NSA project:
Play around with http://acronymcreator.net/ for ideas |
I have to say, Optimist is now my favorite. I wish I'd thought of it myself. |
I also like optimist the best of the remaining names that:
|
yay. only took 1 year, 7 months to come up with a name :( Now let the games begin: https://stackoverflow.com/questions/13440438/how-to-rename-a-gem |
Welp, you know how it is. Hardest 2 things are cache invalidation, naming things, and off-by-one errors :D
… On Apr 10, 2018, at 2:49 PM, Keenan Brock ***@***.***> wrote:
yay. only took 1 year, 7 months to come up with a name :(
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Just got caught up with this again, and I love |
again, apologies for taking so long on this one. Especially for something I feel is so important. Thank you all for pushing us to fix this |
+1 for Let's release ASAP! I have projects waiting on the next version to be pushed to rubygems |
@ddarbyson please help review #99 and make sure we do this right. We need to leave a stable version of trollop up on rubygems.org and make an easy transition to optimist. Gem renames cause headaches for people so we really need to do some collaboration and testing before we complete it. |
Hi @jrafanie seems a bit complicated... Why not just keep Trollop as is and launch Optimist as a new gem at latest version? |
@ddarbyson I think we're saying the same thing. The one caveat that causes people headaches is if |
I understand @jrafanie For the sake of time, can you release the latest set of features which are on master under Trollop and we can work towards renaming for a future release? I'm afraid we might get bogged down and release will take a long time. Reason being, it's becoming more difficult to manage this gem under Bundler as a |
@ddarbyson That is what we did. The latest Trollop code has been released. Sorry, the The |
This is great.... I must have missed the note somewhere along the lines. I see Looking forward to the new name and will keep an eye on this repository. |
@kbrock does it make sense to release a new version as trollop with all the latest changes (without renames) + the VERSION change and that will be the last trollop version (hopefully)? |
yeah, @ddarbyson, I totally agree. We should release the latest version as trollop so people don't need to use git references. We can then go forward with the rename work. |
@jrafanie I'm leaning towards no. Now if we want to merge a few of the PRs (before we bust them so they can't be merged) then I'd be willing to update the internal VERSION number and the external (gemspec) one. Having a single file probably seemed like a good idea a dozen years ago, but it does have its limitations (aka non dry ramifications) |
Sure, that's what I meant but didn't describe properly. 👍
We've had people mention the single file before so we should not make that change in this final patch version before the rename. |
Just bumping this issue to let everyone know that |
Dropping in to say that even though it's Friday night and I'm fixing a broken build pipeline (because the warning message emitted by v2.9.9 broke tests that were expecting a successful command to have no output), I support this change. |
Thanks very much Jason, I appreciate this!
Cheers
Mary-Anne
…On Sat, 25 Aug 2018 at 06:34, Jason Frey ***@***.***> wrote:
Just bumping this issue to let everyone know that optimist has been
released as v3.0.0 and trollop is now deprecated (via a v2.9.9 release).
Thanks everyone for your patience, and all the great naming ideas!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABC4CAep4UYl8cxo-HbG0TqByiOlfdbbks5uUGNIgaJpZM4KFM_Z>
.
|
trollop is now optimist, details at: ManageIQ/optimist#75 ManageIQ/optimist#99
This is my favorite library for option parsing, but I am hesitant to use it in any sort of formal work environment because I know some people may find the project name offensive.
The text was updated successfully, but these errors were encountered: