-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoJS options and quality switch #3
Comments
Hi @devmondo regarding config options, i didnt find any tricks to provide params from JS to Flash using videoJS. Cheers, |
@mangui thank you very much, regarding switching from API manually, is there documentation on that ? |
Hi @devmondo there is no doc, but it is pretty straightforward, from your org.mangui.hls.HLS instance see https://github.com/mangui/flashls/blob/master/src/org/mangui/hls/HLS.as#L76-L94 |
Hi Mangui. You're saying by passing flash params (videojs.options.flash.flashVars) you can't specify those options? I tried looking at the source to see if I could somehow hard code settings but I'm afraid I'm pretty weak at flash. You mentioned using the API but I don't see any reference to that. Appreciate your help. |
@mangui regarding config options: This example contains the embed code generated by video-js Both have hls_capleveltostage=true, video-js still loads the highest resolution available in the m3u8 while OSMF is using a lower level, as it should. |
@ohmercy that's an interesting observation. However, you'll obviously have a different look than the videojs player and I would assume none of the callbacks would work either. I've temporarily solved this by building it myself. The settings can be found here: https://github.com/mangui/flashls/blob/master/src/org/mangui/hls/HLSSettings.as You have to compile flashls then take the output file and put that in the jw-player-swf and compile that. |
@triwav I only isolated the relevant (object) HTML markup generated by video-js, to show the hls_ options are present as flashvars and how both swf plugins handle these flashvars different. Thanks for the tip! Being able to choose different default values is already a step forward. |
So it would appear that the stage size must not be getting properly passed to the script. I've turned on capleveltostage and it just stays on the lowest level. My guess is it's defaulting to 0 thus it's the lowest level always. Could be an error on my side but that definitely puts a damper in things. |
Hi @mangui, |
Hi @Hiroshi-p |
@mangui, Re: logging, I needed to make it because the trace message from flashls itself is not showed on JS console although the one from integration code (HLSProvider.as) is displayed. Is this a known issue of this integration? |
@mangui, |
@mangui, |
@Hiroshi-p |
sorry to sound like a noob but does this mean we can switch quality now :) |
@devmondo, |
@Hiroshi-p thank you very much man :) |
@mangui, |
Hi @Hiroshi-p , the changes looks ok, but I did not test them, I will try to do next week as I will take couple of days off. |
@mangui, |
Capleveltostage seems to be broken in video-js-swf, as triwav mentions above. With hls_capleveltostage enabled, the lowest level is always playing, whatever the embed size of the video player. |
@Hiroshi-p Hope it helps. |
Hi @ohmercy please recheck capleveltostage since last commits |
Hi @mangui capleveltostage is working now |
Hi @mangui, thank you for pulling a change. |
Hi @dacast, it looks like you have your own forked video-js.swf project for the feature. I have not looked at your change, but if you think your design is better than me, feel free to discuss with @mangui to replace mine with yours. I am fine even if my code is dropped as far as the feature is maintained. |
@Hiroshi-p The basic of my videojs module design is the following:
@mangui knows he can reuse my design when he wants. From my opinion, there is no need to pull anything until video.js really implements bitrates/quality messages between player and techs. I have commited a test page in dacast/video-js-swf-flashhls-menu. |
@dacast, thank you for the detail explanation. It sounds like you've already made the same scope of the changes in your own repository. |
No change in video.js. The menu selector is a module. There is just a trick for the display of the active quality used (and so remove highligth on other in the menu). Because menu items are not freely accessible (minified) from videojs.min.js, you may need, or to modify video.js (see exports.js) or to access the minified version of the items (ex something like vjs.N.c.b.a) |
closing, as https://github.com/mangui/video-js-swf provides API for quality switch |
Is there a complete sample how to enable this feature using the latest video-js-sw fork? |
Hi,
-are the Configuration options available in VideoJs implementation?
-can we do quality switch?
thanks in advanced.
The text was updated successfully, but these errors were encountered: