Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up flashls configuration options from flashVars of videojs. #2

Merged
merged 2 commits into from
Aug 7, 2014

Conversation

hohno-panopto
Copy link

No description provided.

@mangui
Copy link
Owner

mangui commented Aug 6, 2014

thanks for the PR, i think it could be really simplify by doing the following:

directly provide loaderInfo.parameters here:
https://github.com/mangui/video-js-swf/blob/master/src/com/videojs/VideoJSModel.as#L599

then in HLSProvider.as, you can inspire from the following code to set options automatically:
https://github.com/mangui/flashls/blob/master/src/org/mangui/flowplayer/HLSProvider.as#L75-L81
using import org.mangui.hls.utils.Params2Settings;

@hohno-panopto
Copy link
Author

Thank you for the review.
That's a great suggestion.
I updated the code and I confirmed this works locally.

@mangui
Copy link
Owner

mangui commented Aug 7, 2014

looks perfect !
thanks

mangui added a commit that referenced this pull request Aug 7, 2014
Hook up flashls configuration options from flashVars of videojs.
@mangui mangui merged commit cb92772 into mangui:master Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants