Remove outdated workarounds to support AGP 3.5.0-alpha12 and beyond #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will achieve compatibility with AGP versions past 3.5.0-alpha12
This reverts commit 926598f.
This can catch incompatibilities in the future, just like the one related to javaOutputDir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the Groovy interop workarounds aren't required anymore, since the AGP API around variants has stabilized significantly since the early days of AGP 3. Moving to the stable artifacts API here, which allows android-junit5 to support AGP 3.5.0-alpha12, which renamed an internal field. To catch this earlier in the future, most functional tests apply the Jacoco plugin to verify that part of the code in an automated fashion.
Also, Gradle 5.4.
Resolves #167