New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_serializer_class for Views without serlaizer_class attribute #92

Merged
merged 3 commits into from May 25, 2016

Conversation

Projects
None yet
3 participants
@EmadMokhtar
Contributor

EmadMokhtar commented May 22, 2016

Sometimes View won't has serliazer_class as DRF documentations, so it's nice to get the serializer class using get_serlizer_class if there is no serliazer_class

@Ivaylo-Bachvarov

This comment has been minimized.

Show comment
Hide comment
@Ivaylo-Bachvarov

Ivaylo-Bachvarov May 22, 2016

Contributor

👍

Contributor

Ivaylo-Bachvarov commented May 22, 2016

👍

@EmadMokhtar

This comment has been minimized.

Show comment
Hide comment
@EmadMokhtar

EmadMokhtar May 25, 2016

Contributor

@ekonstantinidis The issue from CI regarding the npm error

Contributor

EmadMokhtar commented May 25, 2016

@ekonstantinidis The issue from CI regarding the npm error

@manosim

This comment has been minimized.

Show comment
Hide comment
@manosim

manosim May 25, 2016

Owner

That's great @EmadMokhtar! Had to restart Travis several times because it kept erroring (node version?). Will fix that in another PR. Thank you for contributing!

Owner

manosim commented May 25, 2016

That's great @EmadMokhtar! Had to restart Travis several times because it kept erroring (node version?). Will fix that in another PR. Thank you for contributing!

@manosim manosim added the release label May 25, 2016

@manosim manosim merged commit b529776 into manosim:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@manosim

This comment has been minimized.

Show comment
Hide comment
@manosim

manosim May 26, 2016

Owner

@EmadMokhtar Just released 0.0.10 which includes this one!

Owner

manosim commented May 26, 2016

@EmadMokhtar Just released 0.0.10 which includes this one!

@EmadMokhtar

This comment has been minimized.

Show comment
Hide comment
@EmadMokhtar

EmadMokhtar May 26, 2016

Contributor

👍🏻 Nice, I'm so happy 😊😊😊

Contributor

EmadMokhtar commented May 26, 2016

👍🏻 Nice, I'm so happy 😊😊😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment